fix #444: use unsigned bit fields in ObTableBackupFlag to prevent sign ove…#534
Open
ep-12221 wants to merge 1 commit intooceanbase:developfrom
Open
fix #444: use unsigned bit fields in ObTableBackupFlag to prevent sign ove…#534ep-12221 wants to merge 1 commit intooceanbase:developfrom
ep-12221 wants to merge 1 commit intooceanbase:developfrom
Conversation
|
|
ep-12221
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bit-field members has_backup_flag_, has_local_flag_, and reserved_ in ObTableBackupFlag were declared using signed types (ObTableHasBackupFlag::FLAG and int64_t). When stored in a 1-bit bit-field, signed types can only represent the values 0 and -1 (not 0 and 1), causing comparison logic like has_backup_flag_ == ObTableHasBackupFlag::HAS_BACKUP (which compares against 1) to always evaluate to false.
Task Description
fixed #444
Solution Description
Passed Regressions
Upgrade Compatibility
Other Information
Release Note