fix: the wrong logic of constraint checker#540
Open
ep-12221 wants to merge 1 commit intooceanbase:masterfrom
Open
fix: the wrong logic of constraint checker#540ep-12221 wants to merge 1 commit intooceanbase:masterfrom
ep-12221 wants to merge 1 commit intooceanbase:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: ALTER TABLE modifying multiple NOT NULL constraints in one statement does not error as expected
Change the condition in
ObAlterTableConstraintChecker::check_can_add_cst_on_multi_column()
from OB_INVALID_ID == *(*iter)->cst_col_begin() to
OB_INVALID_ID != *(*iter)->cst_col_begin().
OB_INVALID_ID means the NOT NULL constraint belongs to a newly added
column whose column id has not been assigned yet. Multi-column ADD
NOT NULL should only be allowed for that case. The old check treated
multi-column MODIFY ... NOT NULL on existing columns as a valid
multi-column ADD path, so ALTER TABLE succeeded instead of reporting
the expected not supported error.
ref: #530