Open
Conversation
Co-authored-by: footka <[email protected]>
Co-authored-by: footka <[email protected]>
90b2707 to
95a3a7a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task Description
The sort comparator called
fast_check_status()to detect PX interrupts. Once an interrupt was triggered, the comparator returnedfalsefor all subsequent comparisons instead of performing the actual comparison. This broke the strict weak ordering required bystd::sort, causing undefined behavior. Specifically,__unguarded_linear_insertunderflowed the iterator and dereferenced a garbage pointer, leading to amemory_sanity_abort().Solution Description
The fix ensures the comparator maintains strict weak ordering even when an interrupt is detected. The logic was adjusted so that the interrupt status is checked, but the comparator still returns a valid, deterministic boolean result based on the actual data comparison to satisfy the ordering requirements of the sorting algorithm.
Passed Regressions
Upgrade Compatibility
Other Information
Release Note