Skip to content

Conversation

@vouillon
Copy link
Member

No description provided.

in
super#cases cases

method! signature_item item =
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about matching on signature instead of individual items ? Similar to what we do for structures?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OxCaml defines signatures using a record:

and signature =
  {
    psg_modalities : modalities;
    psg_items : signature_item list;
    psg_loc : Location.t;
  }

while mainstream OCaml uses a plain list:

and signature = signature_item list

I did not see any other way to write some code compatible with both.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is unfortunate. Do we really need conditional sig item ? Can you point me to the use cases ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants