dune-project fixes from 5.[89].1 #1053
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
raphael-proust
commented
Mar 7, 2025
raphael-proust
commented
- add explicit version field
- incompatible with ppxlib.0.36.0
- add explicit version field - incompatible with ppxlib.0.36.0
Closed
smorimoto
reviewed
Apr 2, 2025
| @@ -26,10 +26,11 @@ | |||
|
|
|||
| (package | |||
| (name lwt_ppx) | |||
| (version dev) | |||
There was a problem hiding this comment.
I added it mostly because then it's easier to remember to set the version field when doing a release. Otherwise I have to remember to add the version field which I'm likely to forget.
Probably should just write a release script, but in the meantime I'd rather have that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.