Skip to content

Conversation

rand00
Copy link

@rand00 rand00 commented Jun 21, 2022

No description provided.

@rand00
Copy link
Author

rand00 commented Jun 21, 2022

I needed to change the type of Xml to include a Semicolon separator - which demands change to js_of_ocaml-tyxml too. I'll push a PR there too

@rand00
Copy link
Author

rand00 commented Jun 21, 2022

This PR includes #306

@Drup
Copy link
Member

Drup commented Jun 21, 2022

The change to the signature of Xml.S is a rather big breaking change (it breaks not only js_of_ocaml, but also eliom, and all users of the functorial API).

I feel in this case, maybe it's for the best to first do all the renaming and deprecations, make a small release with all the other accumulated small fixes, then make a new big release (with some other breaking changes I accumulated).

@rand00
Copy link
Author

rand00 commented Jun 21, 2022

Okay - but one can't use the Svg.animate with animation-values and key-times without this major change; so makes Svg.animate quite useless anyway. Could postpone the renaming because of that?

@Drup
Copy link
Member

Drup commented Jun 21, 2022

Well, you can always implement it in term of string_attrib. It has less good properties, but it should be sufficient in practice for now.

@rand00
Copy link
Author

rand00 commented Feb 4, 2025

I was just hit by this bug of Tyxml again as I didn't use my fork in another project... TBH feels bad that a library focusing on typesafe HTML5 can't create correct SVG animations. Please either remove the Svg.a_animation_values and Svg.a_keyTimes or allow semicolon-separated lists :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants