Updated to include New, Rising and Controversial filters#36
Open
AdamBissonnette wants to merge 1 commit intooctatone:masterfrom
Open
Updated to include New, Rising and Controversial filters#36AdamBissonnette wants to merge 1 commit intooctatone:masterfrom
AdamBissonnette wants to merge 1 commit intooctatone:masterfrom
Conversation
Fun stuff (my first contribution on GitHub)! In some cases I've wanted to look at the new items in a feed but it didn't seem like this was available. It was really easy to add by adding the values to the sorting select and updating the js to always apply the sorting to the uri since /hot/ works fine for the standard feeds. It seems to work well except sometimes rising glitches out for some reason - meh. Also added some minor css tweaks and batman'd the limit to pull from the Globals in I feel like setting it to 1000 or something crazy the next time I'm working a marathon :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fun stuff (my first contribution on GitHub)!
In some cases I've wanted to look at the new items in a feed but it
didn't seem like this was available. It was really easy to add by
adding the values to the sorting select and updating the js to always
apply the sorting to the uri since /hot/ works fine for the standard
feeds. It seems to work well except sometimes rising glitches out for
some reason - meh.
Also added some minor css tweaks and batman'd the limit to pull from
the Globals in I feel like setting it to 1000 or something crazy the
next time I'm working a marathon :)