Toggle memory profiling start/stop explicitly #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masahi
force-pushed
the
memory-profiling-cleanup
branch
from
721b6f5 to
4154bfe
Compare
sunggg
approved these changes
Feb 15, 2024
|
Thank you! With the changes here, all is running smoothly. |
Lunderberg
pushed a commit
to Lunderberg/mlc-llm
that referenced
this pull request
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we rely on an ugly hack of abusing
UsedMemoryto signal the end of memory profiling, after whichPooledAllocatorswitches to a different pooling mode (another hack). https://github.com/octoml/tvm/blob/for-mlc-serve-jan9/src/runtime/memory/pooled_allocator.h#L114-L116In particular, this hack assumes that
UsedMemoryis called only once, after memory profiling. This blocks #210, which wants to callUsedMemorybefore / after memory-profiling inference.This PR builds on https://github.com/octoml/tvm/pull/45 and explicitly toggles memory profiling start / stop. Please update to the latest
for-mlc-serve-jan12after this PR is merged.@Lunderberg This should unblock your work.
@vinx13 @sunggg