Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix type annotation and run mypy on CI #97

Merged
merged 2 commits into from
Dec 4, 2023
Merged

Fix type annotation and run mypy on CI #97

merged 2 commits into from
Dec 4, 2023

Conversation

masahi
Copy link
Member

@masahi masahi commented Dec 4, 2023 •
edited
Loading

Now mypy is enabled in GH action, see for example https://github.com/octoml/mlc-llm/actions/runs/7085228513

@sunggg @elvin-n

@masahi masahi marked this pull request as draft December 4, 2023 08:01
@masahi masahi force-pushed the mypy-ci branch 2 times, most recently from 3a28664 to 1c35495 Compare December 4, 2023 10:20
@masahi masahi marked this pull request as ready for review December 4, 2023 10:26
@masahi masahi merged commit 19f4cf3 into octoml:batch-serving Dec 4, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@masahi