feat: add catch-all 404 NotFound route - #28
Merged
priscaenoch merged 1 commit intoJul 20, 2026
Conversation
- Add src/pages/NotFound.tsx with clear 404 message, the
unrecognised path, quick-nav links back to main sections,
and a go-back button
- Register <Route path="*" element={<NotFound />}> as the
last route in App.tsx inside the existing ErrorBoundary/
Suspense layout
- Add test/NotFound.test.tsx with 8 tests covering unknown
path rendering and known routes being unaffected
Closes octraban#19
|
@IfyJustin91 is attempting to deploy a commit to the Prisca's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements issue #19 — adds a catch-all
path="*"route so any unknown URL renders a proper 404 page instead of a blank area.Changes
src/pages/NotFound.tsx(new) — 404 page with:404status indicatorsrc/App.tsx— lazy-importsNotFoundand registers<Route path="*" element={<NotFound />} />as the last route, inside the existingErrorBoundary/Suspenselayouttest/NotFound.test.tsx(new) — 8 tests covering://searchis not swallowed by the catch-all/is not swallowed by the catch-allTesting
All 8 new tests pass. TypeScript compiles clean (
tsc --noEmit).Closes #19