Do not attach avatar on omniauth registration if avatar_url is unreachable #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
froger
force-pushed
the
fix/omniauth-404-avatar-url
branch
from
e76ac69 to
b7e889d
Compare
froger
changed the title
|
@froger, the code is OK. I'll test it now. |
froger
force-pushed
the
fix/omniauth-404-avatar-url
branch
from
b7e889d to
4d532af
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
When users login with external login, the OAuth2 server might gives an avatar_url that is not reachable.
This happens using Auth0 when a user have no avatar, Auth0 give back an avatar_url that gives a 404.
📌 Related Issues
Link your PR to an issue
Testing
Describe the best way to test or validate your PR.
Setting up an Auht0 provider, and register your user without any avatar. Auth0 will gives in the payload a default avatar_url that is not accessible, at least in a server-to-server mode.