[FIX] theme_test_custo: correct tour trigger to look for svg images #1102
+5
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@robinlej @loco-odoo What do you think ? Maybe the Img component should have an attribute with the source to be able to check it's value ? <svg t-att-data-src="props.src" ... /> |
robinlej
reviewed
Jun 19, 2025
Since [1], the test "test_01_menu_hierarchies" fails. Note that the check is not as strong as before as we cannot check the source of the image. Since [2], the btn-primary is now btn-secondary --- [1]: odoo/odoo@3cc5ff6 [2]: odoo/odoo@eca4d1b runbot-226641
hubvd
force-pushed
the
master-runbot-226641-huvw
branch
from
e2130ab to
dd45166
Compare
|
I rebased an turns out another change has been made that breaks the tour odoo/odoo@eca4d1b#diff-d3ccab48ea391b9812d735e007298e1d86e6b93b8848fb8204b5be6a6524c40a |
|
@robodoo delegate=robinlej |
|
Yes, thanks :) |
|
@robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
Jun 24, 2025
Since [1], the test "test_01_menu_hierarchies" fails. Note that the check is not as strong as before as we cannot check the source of the image. Since [2], the btn-primary is now btn-secondary --- [1]: odoo/odoo@3cc5ff6 [2]: odoo/odoo@eca4d1b runbot-226641 closes #1102 Signed-off-by: Robin Lejeune (role) <[email protected]>
robodoo
pushed a commit
that referenced
this pull request
Jun 24, 2025
Since [1], the test "test_01_menu_hierarchies" fails. Note that the check is not as strong as before as we cannot check the source of the image. Since [2], the btn-primary is now btn-secondary --- [1]: odoo/odoo@3cc5ff6 [2]: odoo/odoo@eca4d1b runbot-226641 closes #1102 Signed-off-by: Robin Lejeune (role) <[email protected]>
robodoo
pushed a commit
that referenced
this pull request
Jun 24, 2025
Since [1], the test "test_01_menu_hierarchies" fails. Note that the check is not as strong as before as we cannot check the source of the image. Since [2], the btn-primary is now btn-secondary --- [1]: odoo/odoo@3cc5ff6 [2]: odoo/odoo@eca4d1b runbot-226641 closes #1102 Signed-off-by: Robin Lejeune (role) <[email protected]>
robodoo
pushed a commit
that referenced
this pull request
Jun 24, 2025
Since [1], the test "test_01_menu_hierarchies" fails. Note that the check is not as strong as before as we cannot check the source of the image. Since [2], the btn-primary is now btn-secondary --- [1]: odoo/odoo@3cc5ff6 [2]: odoo/odoo@eca4d1b runbot-226641 closes #1102 Signed-off-by: Robin Lejeune (role) <[email protected]>
robodoo
pushed a commit
that referenced
this pull request
Jun 24, 2025
Since [1], the test "test_01_menu_hierarchies" fails. Note that the check is not as strong as before as we cannot check the source of the image. Since [2], the btn-primary is now btn-secondary --- [1]: odoo/odoo@3cc5ff6 [2]: odoo/odoo@eca4d1b runbot-226641 closes #1102 Signed-off-by: Robin Lejeune (role) <[email protected]>
robodoo
pushed a commit
that referenced
this pull request
Jun 24, 2025
Since [1], the test "test_01_menu_hierarchies" fails. Note that the check is not as strong as before as we cannot check the source of the image. Since [2], the btn-primary is now btn-secondary --- [1]: odoo/odoo@3cc5ff6 [2]: odoo/odoo@eca4d1b runbot-226641 closes #1102 Signed-off-by: Robin Lejeune (role) <[email protected]>
robodoo
pushed a commit
that referenced
this pull request
Jun 25, 2025
Since [1], the test "test_01_menu_hierarchies" fails. Note that the check is not as strong as before as we cannot check the source of the image. Since [2], the btn-primary is now btn-secondary --- [1]: odoo/odoo@3cc5ff6 [2]: odoo/odoo@eca4d1b runbot-226641 closes #1102 Signed-off-by: Robin Lejeune (role) <[email protected]>
|
@hubvd can you create the backport in 18.4? |
|
Sure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since 1, the test "test_01_menu_hierarchies" fails.
Note that the check is not as strong as before as we cannot check the
source of the image.
Since 2, the btn-primary is now btn-secondary
runbot-226641