[REF] website: convert default images to WebP format #168862
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
SergeBayet
force-pushed
the
master-default-images-in-webp-seba
branch
from
f95f5b2 to
6a56fc7
Compare
SergeBayet
added a commit
to odoo-dev/design-themes
that referenced
this pull request
Jun 11, 2024
This commit switches the default image format from JPEG to WebP for all design-themes images. WebP offers superior compression compared to JPEG, resulting in smaller file sizes and faster website loading times. Additionally, this change helps avoid warnings from performance tools regarding image optimization. See also: odoo/odoo#168862 task-3167548
SergeBayet
force-pushed
the
master-default-images-in-webp-seba
branch
4 times, most recently
from
10eb820 to
f4a1faf
Compare
SergeBayet
added a commit
to odoo-dev/design-themes
that referenced
this pull request
Jun 25, 2024
This commit switches the default image format from JPEG to WebP for all design-themes images. WebP offers superior compression compared to JPEG, resulting in smaller file sizes and faster website loading times. Additionally, this change helps avoid warnings from performance tools regarding image optimization. See also: odoo/odoo#168862 task-3167548
SergeBayet
force-pushed
the
master-default-images-in-webp-seba
branch
2 times, most recently
from
132d01d to
a286364
Compare
SergeBayet
added a commit
to odoo-dev/design-themes
that referenced
this pull request
Nov 14, 2024
This commit switches the default image format from JPEG to WebP for all design-themes images. WebP offers superior compression compared to JPEG, resulting in smaller file sizes and faster website loading times. Additionally, this change helps avoid warnings from performance tools regarding image optimization. See also: odoo/odoo#168862 task-3167548
qsm-odoo
requested changes
Jun 6, 2025
There was a problem hiding this comment.
@SergeBayet Once you can, this will probably need a rebase too, on top of my comments 🙏 Don't hesitate to push for this kind of PR to be merged quickly. It's partly my fault this lingered in the Testing BE column for this long (even though anyone could have merged it) but... 😉
Comment on lines
486
to
488
| # Currently we're using Pillow 9.0.1, and this version doesn't handle webp | ||
| # We should upgrade to version >=10.1.0. Thus this workaround. |
There was a problem hiding this comment.
I think you can just remove this comment, or add it next to the get_webp_size definiton maybe.
Comment on lines
485
to
490
| if record.mimetype == "image/webp": | ||
| # Currently we're using Pillow 9.0.1, and this version doesn't handle webp | ||
| # We should upgrade to version >=10.1.0. Thus this workaround. | ||
| width, height = tuple(str(size) for size in get_webp_size(image)) | ||
| else: | ||
| img = binary_to_image(image) | ||
| width, height = tuple(str(size) for size in img.size) |
There was a problem hiding this comment.
Is this related to the work you are doing in this commit? I am not sure what this is about but it feels like a fix that maybe should target stable?
There was a problem hiding this comment.
Without this, the tests emit some warnings:
But yes it should target stable. I'm gonna create a PR for this bug-fix.
I'll take care of that as soon as possible. Thanks for the review :) |
SergeBayet
force-pushed
the
master-default-images-in-webp-seba
branch
from
a286364 to
c5ce5d4
Compare
SergeBayet
added a commit
to odoo-dev/design-themes
that referenced
this pull request
Jun 17, 2025
This commit switches the default image format from JPEG to WebP for all design-themes images. WebP offers superior compression compared to JPEG, resulting in smaller file sizes and faster website loading times. Additionally, this change helps avoid warnings from performance tools regarding image optimization. See also: odoo/odoo#168862 task-3167548
SergeBayet
force-pushed
the
master-default-images-in-webp-seba
branch
from
c5ce5d4 to
d367734
Compare
This was referenced Jun 18, 2025
SergeBayet
force-pushed
the
master-default-images-in-webp-seba
branch
from
d367734 to
9fba1b4
Compare
|
@qsm-odoo |
|
robodoo override=ci/style |
SergeBayet
force-pushed
the
master-default-images-in-webp-seba
branch
3 times, most recently
from
6d87a60 to
721f785
Compare
SergeBayet
force-pushed
the
master-default-images-in-webp-seba
branch
2 times, most recently
from
89f46aa to
ead9905
Compare
|
@qsm-odoo PR is ready to be reviewed. Thanks :) |
SergeBayet
force-pushed
the
master-default-images-in-webp-seba
branch
2 times, most recently
from
707cd6e to
7abcae8
Compare
SergeBayet
added a commit
to odoo-dev/design-themes
that referenced
this pull request
Jun 26, 2025
This commit switches the default image format from JPEG to WebP for all design-themes images. WebP offers superior compression compared to JPEG, resulting in smaller file sizes and faster website loading times. Additionally, this change helps avoid warnings from performance tools regarding image optimization. See also: odoo/odoo#168862 task-3167548
SergeBayet
force-pushed
the
master-default-images-in-webp-seba
branch
from
7abcae8 to
4dace49
Compare
SergeBayet
added a commit
to odoo-dev/design-themes
that referenced
this pull request
Jun 27, 2025
This commit switches the default image format from JPEG to WebP for all design-themes images. WebP offers superior compression compared to JPEG, resulting in smaller file sizes and faster website loading times. Additionally, this change helps avoid warnings from performance tools regarding image optimization. See also: odoo/odoo#168862 task-3167548
SergeBayet
force-pushed
the
master-default-images-in-webp-seba
branch
2 times, most recently
from
bb0e873 to
f17006f
Compare
SergeBayet
added a commit
to odoo-dev/design-themes
that referenced
this pull request
Jun 27, 2025
This commit switches the default image format from JPEG to WebP for all design-themes images. WebP offers superior compression compared to JPEG, resulting in smaller file sizes and faster website loading times. Additionally, this change helps avoid warnings from performance tools regarding image optimization. See also: odoo/odoo#168862 task-3167548
This commit switches the default image format from JPEG to WebP for all website images. WebP offers superior compression compared to JPEG, resulting in smaller file sizes and faster website loading times. Additionally, this change helps avoid warnings from performance tools regarding image optimization. task-3167548
SergeBayet
force-pushed
the
master-default-images-in-webp-seba
branch
from
f17006f to
bb8ba42
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit switches the default image format from JPEG to WebP for all website images. WebP offers superior compression compared to JPEG, resulting in smaller file sizes and faster website loading times. Additionally, this change helps avoid warnings from performance tools regarding image optimization.
See also: odoo/design-themes#805
task-3167548