[IMP] qweb: Make t-call parametric, enable lazy XML evaluation #1702
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Polymorphe57
force-pushed
the
master-t-call-dam
branch
4 times, most recently
from
5b2cfaa to
29c594a
Compare
Polymorphe57
changed the title
Polymorphe57
force-pushed
the
master-t-call-dam
branch
12 times, most recently
from
aa0587c to
8d28359
Compare
Polymorphe57
force-pushed
the
master-t-call-dam
branch
4 times, most recently
from
59d5146 to
956d1e1
Compare
Polymorphe57
commented
Oct 10, 2025
| const b2 = ctx[zero]; | ||
| const b3 = ctx[zero]; | ||
| const b2 = ctx[zero]?.(node, key); | ||
| const b3 = ctx[zero]?.(node, key + \`__1\`); |
There was a problem hiding this comment.
useful to have different keys?
Polymorphe57
force-pushed
the
master-t-call-dam
branch
2 times, most recently
from
4445155 to
5fbcb50
Compare
Polymorphe57
force-pushed
the
master-t-call-dam
branch
3 times, most recently
from
31e16a9 to
5efcc86
Compare
The goal is to apply to OWL the same type of changes that were made in odoo/odoo#197296. Note that we have a stricter version here. In case some attrs are found on a t-call, the only parameters given to the template called are the one listed or found in the t-call-context.
Polymorphe57
force-pushed
the
master-t-call-dam
branch
from
54cecf5 to
b97573c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal is to apply to OWL the same type of changes that were made in odoo/odoo#197296.
Note that we have a stricter version here. In case some attrs are found on a t-call, the only parameters given to the template called are the one listed or found in the t-call-context.