refactor(css): replace hardcoded colors and undefined var with theme variables#4656
Open
lucasgab2230 wants to merge 2 commits into
Open
refactor(css): replace hardcoded colors and undefined var with theme variables#4656lucasgab2230 wants to merge 2 commits into
lucasgab2230 wants to merge 2 commits into
Conversation
vdmkenny
reviewed
Jun 23, 2026
vdmkenny
left a comment
Collaborator
There was a problem hiding this comment.
Nice cleanup, this is exactly the direction the style guide wants. I verified the values all line up so there's no visual change in the default theme:
--dangeris genuinely undefined, so the old color was the#f44fallback;--color-erroris#ff4444(the same color), now semantic and theme-aware.--color-mutedis defined as#888, so the#888fallback was redundant and safe to drop.--accent-warmis#d19a66, an exact match for the hardcoded values you replaced, and you correctly left the separate--hl-number(same hex, different meaning) alone.
One thing before it can merge: CONTRIBUTING.md asks for a screenshot on any CSS change ("if you are unsure whether a change is visual, it is"), so please run it locally and attach a quick capture of the affected elements (an orange note, error text, and a muted/context label) so it's on record that they render unchanged. Since this is a value-equivalent refactor that screenshot doubles as the regression check. Looks good otherwise.
Author
|
Ok, wait a moment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Target branch
dev, notmain. All PRs land indev;mainis curated by the maintainer at each release. If your PR is onmainby accident, click "Edit" on this PR and change the base.Linked Issue
Fixes #4655
Type of Change
Checklist
devdocker compose uporuvicorn app:app) and verified the change works end-to-end. Type-checks and unit tests are not enough.How to Test
Visual / UI changes — REQUIRED if you touched anything that renders
Anything that changes what the UI looks like — buttons, icons, padding, colors, fonts, spacing, layout, CSS, HTML, SVG, or any
static/js/module that draws to the DOM — needs all of the following. PRs that change rendering without these WILL be closed.--red,--fg,--bg,--card,--border, etc.) — do not introduce new color values, font sizes, or spacing units.static/index.html) or plain text.Fira Code) for primary UI text. Don't override.Screenshots / clips