refactor(tour): promote shared tour-core.js helper scaffolding#5760
Open
UmutCansinTorgayli wants to merge 1 commit into
Open
refactor(tour): promote shared tour-core.js helper scaffolding#5760UmutCansinTorgayli wants to merge 1 commit into
UmutCansinTorgayli wants to merge 1 commit into
Conversation
github-actions
Bot
added
needs work
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Promote shared onboarding tour scaffolding (styles injection, DOM element highlight halos, tooltip placement math, HTML character streaming, and tour state cancellation) into a reusable
static/js/tour-core.jshelper module as requested in ROADMAP.md.Target branch
dev, notmain.Linked Issue
Part of ROADMAP.md refactor targets #5760.
Type of Change
Checklist
How to Test
node --check static/js/tour-core.jspython -m py_compile tests/test_tour_core_js.py/tourfrom the chat composer to verify step transitions and highlight halos.