Skip to content

refactor(routes): move search domain into routes/search/ subpackage - #5779

Merged
RaresKeY merged 1 commit into
odysseus-dev:devfrom
ydonghao:refactor/routes-search-to-subdir
Jul 28, 2026
Merged

refactor(routes): move search domain into routes/search/ subpackage#5779
RaresKeY merged 1 commit into
odysseus-dev:devfrom
ydonghao:refactor/routes-search-to-subdir

Conversation

@ydonghao

Copy link
Copy Markdown
Contributor

Summary

Slice 2j of the route-domain reorganization (Refs #4082 / #4071). Moves the search domain (111 lines) into routes/search/ behind a sys.modules shim. Pure file reorganization, no behavior change.

One of three parallel low-risk slices (search, vault, webhook). Zero source-introspection landmines. Canonical module imports only from services/ and stdlib.

How to test

python -m compileall routes/search/ routes/search_routes.py app.py
python -m pytest tests/ -q

Target branch

  • This PR targets dev, not main.

Linked Issue

Follows the Phase 0 architecture refactor (#4082 / #4071). One domain per PR.

Type of Change

  • Refactor / cleanup

Checklist

  • I searched open issues and open PRs — this is not a duplicate
  • This PR targets dev
  • My changes are limited to the scope described above — no unrelated refactors
  • No runtime behavior changes (pure file move + import shim)
  • Backward-compatible: old import paths keep working via shim

Slice 2j of the route-domain reorganization (odysseus-dev#4082/odysseus-dev#4071). Moves
search_routes.py into routes/search/, leaving a backward-compat
sys.modules shim. Pure file reorganization, no behavior change.
@github-actions github-actions Bot added the ready for review Description complete — ready for maintainer review label Jul 27, 2026
Comment thread routes/search/search_routes.py Dismissed
Comment thread routes/search/search_routes.py Dismissed
@ydonghao

Copy link
Copy Markdown
Contributor Author

Friendly ping for review 👋

This is one of three parallel low-risk slices (#5779 search, #5780 vault, #5781 webhook). Only the search domain moves — a single-file, 111-line domain with zero internal routes/ coupling — into routes/search/ behind the same sys.modules shim as all previous slices.

Both points from your #4903 review are baked in (canonical doesn't depend on shim; shim regression test included).

Note on CI: The Python tests (pytest) check fails on all PRs currently due to the pre-existing upstream bug #5718 (NameError: name 'Any' is not defined in src/agent_loop.py), not from this PR. Verified locally: the changes pass cleanly when run against a dev HEAD with #5718 fixed.

@RaresKeY @alteixeira20 — would you mind taking a look when you have a moment?

@RaresKeY RaresKeY left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RaresKeY
RaresKeY merged commit 25a4d13 into odysseus-dev:dev Jul 28, 2026
21 of 23 checks passed
entitycs pushed a commit to entitycs/odysseus-svelte that referenced this pull request Jul 28, 2026
…dysseus-dev#5779)

Slice 2j of the route-domain reorganization (odysseus-dev#4082/odysseus-dev#4071). Moves
search_routes.py into routes/search/, leaving a backward-compat
sys.modules shim. Pure file reorganization, no behavior change.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready for review Description complete — ready for maintainer review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants