Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs/grid icons #1168

Open
wants to merge 4 commits into
base: docs/make-style-modern
Choose a base branch
from
Open

Conversation

leroum
Copy link

@leroum leroum commented Feb 28, 2025

Grid icons are now matching to the articles. Alls light mode icons are there now. But the ones for the ldark mode which need oemof.visio are still not there (waiting for some ajustments in visio)

@leroum leroum changed the base branch from dev to docs/make-style-modern March 1, 2025 18:31
Copy link
Contributor

@Bachibouzouk Bachibouzouk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comments in the two python files are in german, it is intentional?

Apart from this I would say it is good to merge

esgr = ESGraphRenderer(
energysystem_model,
legend=False,
filepath="D:/ES.svg",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
filepath="D:/ES.svg",
filepath="ES.svg",

The example with D:/ will only work for windows users and for windows users having a drive under this address.

@@ -0,0 +1,285 @@
import matplotlib.colors as mcolors
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A docstring to this module would be helpful. As far as I understood it is generating figures of the doc, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants