fix: version dropdown regex + Pages deploy for archived builds#12
Merged
Conversation
The non-greedy regex stopped at the inner }, of dropdownItemsAfter
instead of the outer }, closing the whole navbar item. Use \n\s{8}\},\n
to match the 8-space-indented closing brace of the top-level item.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
5f2a496 to
9ac8c63
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BUILDING_LATESTgate from the Pages artifact upload and deploy steps so archived version builds (e.g., v0.7.0) actually get deployed to GitHub PagesdocsVersionDropdownwith a custom dropdown populated fromversionsArchived.json— latest build shows "main (unreleased)", archived builds show their version tag},ofdropdownItemsAfterinstead of the outer block, causing a TypeScript parse error. Anchored to the 8-space-indented closing brace instead.Test plan
🤖 Generated with Claude Code