Skip to content

[osh refactor] Simplify GlobUnescapeBackslash() even more? #2400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[osh refactor] Simplify GlobUnescapeBackslash() even more? #2400

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 1 addition & 23 deletions osh/glob_.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,29 +169,7 @@ def GlobUnescape(s):
def GlobUnescapeBackslash(s):
# type: (str) -> str
"""Inverse of GlobEscapeBackslash - turns \@ into \ """
unescaped = [] # type: List[int]
i = 0
n = len(s)
while i < n:
c = mylib.ByteAt(s, i)

if mylib.ByteEquals(c, '\\') and i != n - 1:
# Note: GlobEscapeBackslash() doesn't turn \ into \\, so a string
# could end with a single backslash?
assert i != n - 1, 'Trailing backslash: %r' % s

i += 1
c2 = mylib.ByteAt(s, i)

if mylib.ByteEquals(c2, '@'):
unescaped.append(pyos.BACKSLASH_CH)
else:
unescaped.append(pyos.BACKSLASH_CH)
unescaped.append(c2)
else:
unescaped.append(c)
i += 1
return mylib.JoinBytes(unescaped)
return s.replace('\\@', '\\')


# For ${x//foo*/y}, we need to glob patterns, but fnmatch doesn't give you the
Expand Down