Fix py_structs import errors across codebase#49
Open
kanishkaganguly wants to merge 1 commit intooliver-batchelor:masterfrom
Open
Fix py_structs import errors across codebase#49kanishkaganguly wants to merge 1 commit intooliver-batchelor:masterfrom
kanishkaganguly wants to merge 1 commit intooliver-batchelor:masterfrom
Conversation
Owner
|
I have committed a change to setup.py to change the dependency to py_structs < 1.0 (which is where the refactoring h to move the modules around happened). If you're confident that it still works with these changes, I'm happy to commit it; really, it needs a basic test to check the functionality still works - but I'm not really using this for anything lately, so I've got zero time allocated to work on something like this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When installing from source using
python3 -m pip install ".[interactive]"and trying to runmultical -h, there are import errors across multiple files.This is running on Python3.8 inside a virtual environment.
Upon investigation, it would appear to be originating from the
py_structspackage, which seems to be using a different directory structure than whatmulticalis expecting. This might be due to a change upstream, maybe.This PR fixes all import errors and allows
multical -hto run without crashing/errors. Whether calibration actually works is a different issue, and is under testing.