-
Notifications
You must be signed in to change notification settings - Fork 35
getObject() and getExternalInfo() load externalInfo #453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
559333d
to
40028fa
Compare
40028fa
to
295d948
Compare
@jburel I added support for:
so we can set |
Conflicting PR. Removed from build OMERO-python-superbuild-push#350. See the console output for more details.
--conflicts |
Conflicting PR. Removed from build OMERO-python-superbuild-push#351. See the console output for more details.
--conflicts |
Conflicting PR. Removed from build OMERO-python-superbuild-push#352. See the console output for more details.
--conflicts |
Conflicting PR. Removed from build OMERO-python-superbuild-push#353. See the console output for more details.
--conflicts |
Conflicting PR. Removed from build OMERO-python-superbuild-push#354. See the console output for more details.
--conflicts |
Conflicting PR. Removed from build OMERO-python-superbuild-push#355. See the console output for more details.
--conflicts |
Conflicting PR. Removed from build OMERO-python-superbuild-push#356. See the console output for more details.
--conflicts |
Conflicting PR. Removed from build OMERO-python-superbuild-push#357. See the console output for more details.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me.Thanks Will, useful command!
See ome/omero-web#613.
This tweaks the base
BlitzObjectWrapper._getQueryString()
to include loadingexternalInfo
.It also adds
BlitzObjectWrapper.getExternalInfo()
to return theexternalInfo
and load it if necessary, e.g. for cases whereself._obj
is NOT the object loaded bygetObject()
.E.g. for image:
To test:
Set some values for ExternalInfo:
Using this branch:
Since the JSON API uses
_getQueryString()
to build queries, and omero-marshal already handles externalInfo, you can check the details at E.g./api/v0/m/images/ID/
: (NB: deployed on idr-testing, e.g./api/v0/m/images/15159664/
).