Fixed import when there are empty rows.#190
Fixed import when there are empty rows.#190Daniel-KM wants to merge 1 commit intoomeka-s-modules:developfrom
Conversation
|
What's the problem currently when there are blank rows? What gets skipped? |
|
Not sure if this is the issue, but when csvimport meets a blank row, it may not return next rows. |
|
The issue occurs with the last version of box/spout, not v3.0. |
|
I would guess that based on how the iterators and things work, if there were blank lines and the underlying iterator auto-skips them, you'd lose rows when moving to later "batches" as we try to skip to the correct starting point. And for your clarification, this is only with a further updated version of spout than we're currently using? So maybe this fix should go along with such an update to the dependency (if that's needed). Or is the problem with a previous version? |
|
What is missing in many modules (and omeka in fact) is phpunit tests, so i have to check more to understand the issue i had. |
2 participants
A fix for the version v3 of box/spout.