feat: Add newline normalization to spec. #84
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alilleybrinker
added
c-spec
This updates the spec to reflect the need to do newline normalization for cross-platform consistency purposes. Without this normalization, files which are identical but are checked out on Windows vs. Unix systems in Git will have different identifiers, which is not ideal. This normalization is already implemented in the OmniBOR Rust implementation. Signed-off-by: Andrew Lilley Brinker <[email protected]>
alilleybrinker
force-pushed
the
alilleybrinker/normalize-newlines
branch
from
3e8e197 to
aa93209
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the spec to reflect the need to do newline normalization for cross-platform consistency purposes. Without this normalization, files which are identical but are checked out on Windows vs. Unix systems in Git will have different identifiers, which is not ideal.
This normalization is already implemented in the OmniBOR Rust implementation.
Closes #82