Update to PHPStan 2.0, fix all issues

.gitignore

@@ -1,3 +1,4 @@
-.phpunit.cache/
 .php-cs-fixer.cache
+.phpunit.cache/
+phpstan.neon
 vendor/

composer.json

@@ -34,8 +34,8 @@
     "require-dev": {
         "friendsofphp/php-cs-fixer": "^3.17",
         "php-parallel-lint/php-parallel-lint": "^1.3",
-        "phpstan/phpstan": "^1.9",
-        "phpstan/phpstan-phpunit": "^1.3.3",
+        "phpstan/phpstan": "^2.0",
+        "phpstan/phpstan-phpunit": "^2.0",
         "phpunit/phpunit": "^11.0"
     },
     "scripts": {

phpstan.neon → phpstan.neon.dist

@@ -5,3 +5,4 @@ parameters:
     paths:
         - %currentWorkingDirectory%/src
         - %currentWorkingDirectory%/tests
+    treatPhpDocTypesAsCertain: false

src/IrcChannel.php

@@ -14,7 +14,7 @@
 
 class IrcChannel
 {
-    private ?string $topic;
+    private string $topic = '';
 
     /** @var array<int, string> */
     private array $users = [];
@@ -31,18 +31,12 @@ public function __construct(private string $name)
         }
     }
 
-    /**
-     * Fetch the name of the channel, including the `#`.
-     */
     public function getName(): string
     {
         return $this->name;
     }
 
-    /**
-     * Get the current channel topic.
-     */
-    public function getTopic(): ?string
+    public function getTopic(): string
     {
         return $this->topic;
     }
@@ -56,10 +50,6 @@ public function getUsers(): array
         return $this->users;
     }
 
-    /**
-     * Set the current channel topic.
-     * @param string $topic The topic
-     */
     public function setTopic(string $topic): void
     {
         $this->topic = $topic;

tests/IrcMessageParserTest.php

@@ -89,7 +89,6 @@ public function testMotd(): void
         foreach ($this->parser->parse($message) as $parsed) {
             $count++;
             self::assertInstanceOf(MOTDMessage::class, $parsed);
-            self::assertInstanceOf(IrcMessage::class, $parsed);
         }
         self::assertSame(9, $count);
     }