Handle apps without a binary name in session finder - #161
Open
szwoloszyn wants to merge 2 commits into
Open
Conversation
Added if statement for applications without a binary name.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently, on Linux, if a PulseAudio/PipeWire sink input does not provide the
application.process.binaryproperty,deejignores the stream entirely and logs a "Failed to get sink input's process name" warning.This happened to me with application running through compatibility layer. For example, when Firefox is forced to use the ALSA backend over PipeWire (
media.cubeb.backend = alsa- did it as a workaround for volume-jumping issues in Linux desktop environments), it only providesapplication.name.Solution
Added a simple if statement in
pkg/deej/session_finder_linux.go. If theapplication.process.binaryproperty is not found (!ok), the code now attempts to fetchapplication.namebefore giving up and dropping the stream.Impact
Streams that were previously ignored and generated warnings (e.g.,
ALSA plug-in [firefox-esr]) are now successfully tracked as sessions and can be mapped to sliders inconfig.yaml.