Skip to content

Handle apps without a binary name in session finder - #161

Open
szwoloszyn wants to merge 2 commits into
omriharel:masterfrom
szwoloszyn:master
Open

Handle apps without a binary name in session finder#161
szwoloszyn wants to merge 2 commits into
omriharel:masterfrom
szwoloszyn:master

Conversation

@szwoloszyn

Copy link
Copy Markdown

Description

Currently, on Linux, if a PulseAudio/PipeWire sink input does not provide the application.process.binary property, deej ignores the stream entirely and logs a "Failed to get sink input's process name" warning.

This happened to me with application running through compatibility layer. For example, when Firefox is forced to use the ALSA backend over PipeWire (media.cubeb.backend = alsa - did it as a workaround for volume-jumping issues in Linux desktop environments), it only provides application.name.

Solution

Added a simple if statement in pkg/deej/session_finder_linux.go. If the application.process.binary property is not found (!ok), the code now attempts to fetch application.name before giving up and dropping the stream.

Impact

Streams that were previously ignored and generated warnings (e.g., ALSA plug-in [firefox-esr]) are now successfully tracked as sessions and can be mapped to sliders in config.yaml.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant