-
Notifications
You must be signed in to change notification settings - Fork 1
Add publish-pypi workflow #13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| name: "Publish on PyPI" | ||
|
|
||
| # This workflow is triggered when a new release is published on GitHub. It | ||
| # builds the package and uploads it to PyPI. | ||
|
|
||
| on: | ||
| release: | ||
| types: [published] | ||
|
|
||
| jobs: | ||
| deploy_pypi: | ||
| if: ${{ github.repository == 'omsf/spec0' }} | ||
| runs-on: ubuntu-latest | ||
| name: "Publish on PyPI" | ||
| permissions: | ||
| id-token: write | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - uses: actions/setup-python@v5 | ||
| with: | ||
| python-version: "3.x" | ||
| - name: "Install release tools" | ||
| run: | | ||
| python -m pip install twine build | ||
| - name: "Build and check package" | ||
| run: | | ||
| python -m build --sdist --wheel | ||
| twine check dist/* | ||
| - name: "Publish on pypi" | ||
| uses: pypa/gh-action-pypi-publish@release/v1 | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pin the action to a specific commit hash instead of using the mutable 'release/v1' tag to prevent supply chain attacks. For example, use a format like 'pypa/gh-action-pypi-publish@81e9d935c883d0b210363ab89cf05f3894778450'.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand the recommendation, but since I'm going to do a video on this, I'm going to keep it clear (and recommend that viewers check whatever the most recent hash is).