Conversation
… + sweep) Item 1: 0000-template gains the rule — write the invariant and boundary condition, not the APIs that implement it today; implementation detail lives in docs/ and code comments. Sweep of the worst mechanism accumulators, keeping decision + invariant + provenance: - 0011: helper invocation detail (binary names, runas/pkexec/osascript, Subprocess.call, exit-code mapping) → pointer to docs/auto-updater.md. - 0019: the self-update section drops the managed-block JSON field names and BUILD_DATE conf name; #341 noted as the mechanism's future home. - 0026: the STABLE_* generated-key list becomes "baked fallback URLs, generated from installer.conf per 0013" (names live in DEVELOPING.md). No decision changes — the records decide the same things they decided before; only the mechanism duplication is gone. Part of #334 (each item lands as its own PR). 🤖 Generated with Codebuff Co-Authored-By: Codebuff <noreply@codebuff.com>
Owner
Author
|
Superseded by #357, which carries this PR's commits unchanged (fresh branch off main @ f01043f, cherry-picked as agreed in #334 — no rebase, no re-triggered CI). This PR stays closed; review the content on #357. 🤖 Closed as superseded by the Codebuff agent (Buffy) per the maintainer's #334 instruction to consolidate the doc work in one fresh PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Item 1 — template rule:
docs/decisions/0000-template.mdgains the one-line rule in its Decision section: record the decision, not the mechanism — write the invariant and boundary condition, not the APIs that implement it today. Future records stop re-accumulating identifiers like the ones ADR 0012 had collected (b.addTrustedTab,nsITimer,skippedHash.*— trimmed in 5133f84).Item 2 — sweep of the worst accumulators (verified by grepping all 36 records for mechanism identifiers; the names already live in
docs/auto-updater.md/docs/DEVELOPING.md/ AGENTS.md / code — nothing is lost):runas/pkexec/osascript,Subprocess.call, exit-code mapping,IOUtils/commit refs) → decision kept (standalone per-OS helper, fresh download, one elevation, distinct cancel exit code, direct-copy-first) + pointer todocs/auto-updater.md.installerDate, download-map shape) and theBUILD_DATEconf key name; notes Move the installer self-update block out of installer-<date> release bodies to gh-pages (post-v1.0) #341 as the mechanism's future home. Decision intact: date-based detection, body ingestion via/releases, silent-when-absent.STABLE_HASHES_URL/STABLE_ZIP_BASE_URL/STABLE_UI_BASE_URL/STABLE_HELPER_BASE_URLlist becomes "a set of stable-channel fallback URLs, generated fromconfig/installer.confper [0013]"; key names live indocs/DEVELOPING.md(+auto-updater.md:160keeps theSTABLE_*mention).Candidates checked and left as-is: 0005 (no transport APIs — clean), 0024/0027/0030/0031/0035/0036/0013/0016/0007/0003/0006/0032 (asset names / file names are the subject of those decisions — e.g. 0024 defines the asset set by name, 0035 defines the sidecar-naming rule; removing them would gut the decision).
Validation
pnpm check:decisions✓ (36 records, links/statuses/amendments OK)pnpm format(markdownlint) ✓ · no code touchedPart of #334. Items 3–5 (future-work.md retirement, AGENTS.md pointers, roadmap.md decision) stay open as their own PRs.
🤖 Generated with Codebuff
Co-Authored-By: Codebuff noreply@codebuff.com