Skip to content

Conversation

@nialexsan
Copy link
Contributor

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Aug 4, 2023

⚠️ No Changeset found

Latest commit: 4b80418

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

nialexsan and others added 7 commits August 4, 2023 10:38
* switch to uuid from @onflow/utils-uid

* create tsconfigs

* typedefs in ts

* types for actor util

* types for address util

* Revert "switch to uuid from @onflow/utils-uid"

This reverts commit 2a15ef5.

* PKG -- [util-actor] converted to ts

* updated tsconfig

* fixed ts types generation

* Resolve circular dependency

* ts rlp

* change type location

* more types

* build types during regular build

* fix tests

* VSN -- [root] Changeset

* Merge remote-tracking branch 'origin/master' into nialexsan/add-types

* Revert "Resolve circular dependency"

This reverts commit 36efc7d.

* update lock

* VSN -- [root] changeset
Implements typescript support for: @onflow/rlp, @onflow/util-uid, @onflow/util-template, @onflow/util-logger, @onflow/util-invariant, @onflow/util-encode-key, @onflow/util-address
@jribbink
Copy link
Contributor

jribbink commented Aug 16, 2023

Just flagging here: it doesn't appear that the jsdoc generated types are working on this branch anymore. So if this is released/merged into master at any point, one of the following 2 criteria must be met.

  1. Typescript conversion is complete and no JSDoc types exist anymore (hopefully this is the case)
  2. OR we fix the jsdoc types and have a mix of both jsdoc-generated and typescript types

otherwise this branch will introduce a regression in type definitions

jribbink and others added 4 commits August 25, 2023 13:11
* [WIP] Convert @onflow/types to TS

* stash

* kind of working

* fix package.json

* fix dictionary

* fix tests

* stash

* strong type tests

* remove any

* rename

* changeset
@nialexsan nialexsan marked this pull request as ready for review September 1, 2023 13:57
@nialexsan nialexsan requested a review from a team as a code owner September 1, 2023 13:57
@nialexsan nialexsan closed this Sep 1, 2023
@nialexsan nialexsan deleted the release-1.6 branch September 1, 2023 21:23
@nialexsan nialexsan mentioned this pull request Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants