Include system transactions in flow blocks get <txid> --include transactions
#2211
+73
−32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jribbink
requested review from
Kay-Zee,
bjartek,
chasefleming,
janezpodhostnik,
mfbz and
nvdtf
as code owners
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
jribbink
force-pushed
the
jribbink/get-block-system-txns
branch
from
4736789 to
f2fd5c5
Compare
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
jribbink
added
the
Improvement
mfbz
reviewed
Dec 2, 2025
internal/blocks/blocks.go
Outdated
| txs = append(txs, tx.String()) | ||
| collections = append(collections, collection) | ||
| } | ||
| result["collections"] = collections |
Contributor
There was a problem hiding this comment.
the key was "collection" before, should we keep it like that for backward compatibility?
Contributor
Author
There was a problem hiding this comment.
Yeah, probably best practice good catch ty
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2185
Description
This adds system transactions to
flow blocks get <txid> --include transactions.Previously, we were just using the transaction IDs listed in the response, per collection. However - this does not cover transactions included outside of regular block production (system transactions).
To work around this, we make an additional
GetTransactionsByBlockIdrequest to query more robust block metadata relating to transactions.For contributor use:
masterbranchFiles changedin the Github PR explorer