-
Notifications
You must be signed in to change notification settings - Fork 9
Update imports to be replaced from config #78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe changes update three Cadence files by replacing hardcoded contract addresses for Changes
Sequence Diagram(s)Possibly related PRs
Suggested reviewers
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (3)
script/cadence/scripts/get-balances-basic.cdc (1)
1-2
: Dynamic Import Placeholder UpdateThe import statements have been correctly updated to use template placeholders (
0x{{.Contracts.FlowToken}}
and0x{{.Contracts.FungibleToken}}
). This change enhances deployment flexibility by deferring the binding of contract addresses to configuration rather than hardcoding them.script/cadence/transactions/basic-transfer.cdc (1)
1-2
: Updated Import Placeholders in Transaction ScriptThe updated import statements now make use of the template placeholders, ensuring that contract addresses are provided dynamically at deployment. This update is consistent with the overall objective of reducing hardcoded values.
script/cadence/scripts/get-balances.cdc (1)
5-6
: Consolidated Import Update in Get-Balances ScriptThe changes on lines 5 and 6 replace hardcoded contract addresses with template placeholders. This refactor supports dynamic resolution of the contract addresses at deployment time and aligns with similar updates made elsewhere in the codebase. Please verify that the deployment configuration includes the necessary mappings for
Contracts.FlowToken
andContracts.FungibleToken
to avoid runtime errors.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
script/cadence/scripts/get-balances-basic.cdc
(1 hunks)script/cadence/scripts/get-balances.cdc
(1 hunks)script/cadence/transactions/basic-transfer.cdc
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: test
Summary by CodeRabbit