Skip to content

Update imports to be replaced from config #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 1, 2025

Conversation

franklywatson
Copy link
Contributor

@franklywatson franklywatson commented Apr 1, 2025

Summary by CodeRabbit

  • Refactor
    • Updated token contract address referencing to use dynamic configuration, which streamlines deployment while maintaining current functionality.

@franklywatson franklywatson requested a review from a team as a code owner April 1, 2025 16:23
Copy link

coderabbitai bot commented Apr 1, 2025

Walkthrough

The changes update three Cadence files by replacing hardcoded contract addresses for FlowToken and FungibleToken with template placeholders. This refactor spans two scripts (get-balances-basic.cdc and get-balances.cdc) and one transaction (basic-transfer.cdc), allowing dynamic resolution of the contract addresses at deployment. The business logic in the code remains unchanged.

Changes

File(s) Change Summary
script/cadence/scripts/get-balances-basic.cdc
script/cadence/scripts/get-balances.cdc
script/cadence/transactions/basic-transfer.cdc
Replaced hardcoded imports of FlowToken and FungibleToken with template placeholders (0x{{.Contracts.FlowToken}} and 0x{{.Contracts.FungibleToken}}) for dynamic address resolution.

Sequence Diagram(s)

Possibly related PRs

Suggested reviewers

  • koko1123

Poem

I'm a rabbit, quick on my feet,
Hopping through code with a rhythmic beat.
Hardcoded chains now set free,
As templates leap into flexibility!
Cheers to changes that make our code complete!
🐇💻


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (3)
script/cadence/scripts/get-balances-basic.cdc (1)

1-2: Dynamic Import Placeholder Update

The import statements have been correctly updated to use template placeholders (0x{{.Contracts.FlowToken}} and 0x{{.Contracts.FungibleToken}}). This change enhances deployment flexibility by deferring the binding of contract addresses to configuration rather than hardcoding them.

script/cadence/transactions/basic-transfer.cdc (1)

1-2: Updated Import Placeholders in Transaction Script

The updated import statements now make use of the template placeholders, ensuring that contract addresses are provided dynamically at deployment. This update is consistent with the overall objective of reducing hardcoded values.

script/cadence/scripts/get-balances.cdc (1)

5-6: Consolidated Import Update in Get-Balances Script

The changes on lines 5 and 6 replace hardcoded contract addresses with template placeholders. This refactor supports dynamic resolution of the contract addresses at deployment time and aligns with similar updates made elsewhere in the codebase. Please verify that the deployment configuration includes the necessary mappings for Contracts.FlowToken and Contracts.FungibleToken to avoid runtime errors.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 83fafa6 and 192f9d5.

📒 Files selected for processing (3)
  • script/cadence/scripts/get-balances-basic.cdc (1 hunks)
  • script/cadence/scripts/get-balances.cdc (1 hunks)
  • script/cadence/transactions/basic-transfer.cdc (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: test

@franklywatson franklywatson merged commit 6052b63 into main Apr 1, 2025
1 check passed
@franklywatson franklywatson deleted the jp/script-imports-2 branch April 1, 2025 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants