Skip to content

Conversation

pmishev
Copy link
Contributor

@pmishev pmishev commented Mar 11, 2021

Allow null 'format' in DateRangeAggregation

Without this, calling:

        $ranges[] = ['from' => time()-1000, 'to' => time(), 'key' => 'time_range'];
        $rangeAgg = new DateRangeAggregation('myagg', 'created', null, $ranges, true);

results in an exception, but it shouldn't as format is optional.

@pmishev
Copy link
Contributor Author

pmishev commented Jun 9, 2022

Have you considered merging this fix?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant