Allow editing classless resources - #1245
Draft
joepio wants to merge 2 commits into
Draft
Conversation
ResourceForm no longer hard-blocks when isA is missing or not a Class. It renders existing properties and keeps Advanced add-property available, with a soft warning when isA points at a non-Class. Adds an e2e covering the classless edit path. Closes #1158 Co-authored-by: Joep Meindertsma <joep@ontola.io>
ResourceField uses data-test, not data-testid, for normal inputs. Co-authored-by: Joep Meindertsma <joep@ontola.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
closes #1158
Summary
ResourceFormhard-blocked wheneverisAwas missing or did not resolve to a Class, showing:Class was only needed to pick required/recommended fields. Existing properties were already collected in
otherProps, and Advanced already supports adding new properties.This makes Class advisory: when valid, required/recommended fields still render; otherwise the form shows current properties and lets the user add more. A soft warning appears when
isApoints at a non-Class.Changes
ResourceForm; only wait on Class loading when a class subject is presentisAis set but not a ClassisA, open/app/edit, assert the form renders and Save is enabledTESTING_COVERAGE.mdrow@tomic/libstoreChecklist