-
Notifications
You must be signed in to change notification settings - Fork 91
chore(node/p2p): Forward Discovery Events #1495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📚
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR addresses the issue of properly forwarding valid ENRs from the discv5 discovery driver to the gossip driver. Key changes include:
- Adding a retry loop to continuously attempt to start the event stream.
- Incorporating new event handling branches for both Discovered and SessionEstablished events.
- Forwarding valid ENRs to the store and asynchronously sending them to the swarm.
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
5cd291f
to
2bd854f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
check out reth's discv5 workaround for geth enrs. sigp/discv5 is much stricter about correct enr configuration for its peers than geth, so we had to ask sigp to add this special new event for being geth compatible when using sigp/discv5 for EL
https://github.com/paradigmxyz/reth/blob/dd4aa1a85b5babbcedf2a5978cd88b631bc486e8/crates/net/discv5/src/lib.rs#L255-L283
5524501
to
07b7de8
Compare
Co-authored-by: Emilia Hane <[email protected]>
07b7de8
to
8f15f7c
Compare
Looks great thanks for taking care of it! |
Description
Fixes the
kona-node
discovery driver to properly forward valid ENRs discovered throughdiscv5
to the gossip driver