Programmatic store screenshot generation

[opatry]

Description

• Add adb_demo_mode.sh script to ease screenshot generation

• Introduce demo flavor

• Create pre-filled Demo content

• Add StoreScreenshotTest to generate store screenshots programmatically

• Only relying on TestTasksApplication instead of a dedicated flavor could simplify the whole thing

  • move dependencies from demoImplementation to androidTestImplementation
  • move the flavor init mechanism from flavor to test (and remove dummy/empty impls)
  • find a way to determine which is the test (class) being launch, if it's screenshot gen, then trigger the flavor init mechanism now available on tests
  • ➡️ or use Koin & DI from test to tweak behavior locally

class KoinTestRule(
    private val modules: List<Module>
) : TestWatcher() {
    override fun starting(description: Description) {
        if (getKoinApplicationOrNull() == null) {
            startKoin {
                androidContext(InstrumentationRegistry.getInstrumentation().targetContext.applicationContext)
                modules(modules)
            }
        } else {
            loadKoinModules(modules)
        }
    }

    override fun finished(description: Description) {
        unloadKoinModules(modules)
    }
}

    @get:Rule
    val koinTestRule = KoinTestRule(
        listOf(
            // here tweak module with prefilled DB
            databaseTestModule,
            ...
        )
    )

• Fix test package name
• Fix screenshot rule package name

Checklist

• I have read the CONTRIBUTING guide
• Code compiles correctly
• Created tests which fail without the change (if possible)
• All tests passing

[github-actions]

Job Summary for Gradle

Build & Test :: build

Gradle Root Project	Requested Tasks	Gradle Version	Build Outcome	Build Scan®
Taskfolio	:tasks-app-desktop:assemble	8.12.1	✅
Taskfolio	:tasks-app-android:assembleStoreRelease	8.12.1	✅
Taskfolio	test :tasks-app-android:testStoreReleaseUnitTest jvmTest	8.12.1	❌
Taskfolio	:tasks-app-android:exportLibraryDefinitions	8.12.1	✅
Taskfolio	:tasks-app-desktop:exportLibraryDefinitions	8.12.1	✅

[opatry]

Suggested change

	compose = "1.8.0"
	compose = "1.8.2"

[opatry]

• check latest version before merging

[opatry]

/gemini review this pr

[gemini-code-assist]

Code Review

The pull request introduces a 'demo' flavor to facilitate programmatic screenshot generation for the store, along with UI tests and scripts to automate the process. The changes include adding dependencies, creating a demo flavor, pre-filling demo content, and adding a screenshot test. The code looks well-structured and addresses the stated goals.

[gemini-code-assist]

Consider moving this dependency to androidTestImplementation if it's only needed for tests. This avoids including it in the main application code, reducing the app size. If tasksCore is truly needed for prefilled content in the demo flavor's main code (not just the tests), then this placement is correct.

[gemini-code-assist]

The comment suggests that using Room's preloaded data mechanism would be more elegant. If feasible, explore this option to simplify the initialization process and potentially improve performance. If the programmatic approach is preferred due to easier evolution, consider documenting the reasons for this choice more explicitly.

[gemini-code-assist]

This logic deletes the database if the target is 'test' or 'demo'. While this is useful for testing and demo purposes, ensure that this behavior is clearly documented and doesn't inadvertently affect production or development environments. Consider using a more specific flag or environment variable to control this behavior.