MultimodalQnA Image and Audio Support Phase 1 #1071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Melanie Buehler <[email protected]>
* added entrypoint override Signed-off-by: okhleif-IL <[email protected]> * fixed entrypoint container Signed-off-by: okhleif-IL <[email protected]> * removed workdir Signed-off-by: okhleif-IL <[email protected]> * reverted set env vars changes Signed-off-by: okhleif-IL <[email protected]> * added entrypoint for embedding model Signed-off-by: okhleif-IL <[email protected]> * added llava model to readme Signed-off-by: okhleif-IL <[email protected]> * removed stray \n Signed-off-by: okhleif-IL <[email protected]> * added entrypoint override in bridgetower hpu Signed-off-by: okhleif-IL <[email protected]> --------- Signed-off-by: okhleif-IL <[email protected]>
Signed-off-by: Melanie Buehler <[email protected]>
Signed-off-by: Melanie Buehler <[email protected]>
…e/mm-rag-enhanced
* changed variable names Signed-off-by: okhleif-IL <[email protected]> * changed gaudi env vars Signed-off-by: okhleif-IL <[email protected]> * changed vars + docs Signed-off-by: okhleif-IL <[email protected]> * verified + updated readme Signed-off-by: okhleif-IL <[email protected]> * updated readme Signed-off-by: okhleif-IL <[email protected]> * updated tests Signed-off-by: okhleif-IL <[email protected]> --------- Signed-off-by: okhleif-IL <[email protected]>
Signed-off-by: okhleif-IL <[email protected]>
Signed-off-by: Melanie Buehler <[email protected]>
…estion Image ingestion improvements
…e/mm-rag-enhanced
Signed-off-by: dmsuehir <[email protected]>
Update LVM model for Xeon
Signed-off-by: Melanie Buehler <[email protected]>
Signed-off-by: Melanie Buehler <[email protected]>
Signed-off-by: Melanie Buehler <[email protected]>
Signed-off-by: dmsuehir <[email protected]>
…e/mm-rag-enhanced
Signed-off-by: dmsuehir <[email protected]>
Signed-off-by: Melanie Buehler <[email protected]>
Signed-off-by: Melanie Buehler <[email protected]>
Image+Text Upload
Signed-off-by: Melanie Buehler <[email protected]>
UI Audio Upload
Signed-off-by: Melanie Buehler <[email protected]>
Signed-off-by: Melanie Buehler <[email protected]>
Signed-off-by: Melanie Buehler <[email protected]>
Signed-off-by: Melanie Buehler <[email protected]>
ashahba
approved these changes
Nov 6, 2024
There was a problem hiding this comment.
Thanks @mhbuehler @dmsuehir and @okhleif-IL for this well put together PR!
LGTM!
Signed-off-by: Melanie Buehler <[email protected]>
Updated main README and supported_examples with MMQA details
for more information, see https://pre-commit.ci
Fix for lvm-dependent tests and clear textbox
Signed-off-by: okhleif-IL <[email protected]>
ashahba
reviewed
Nov 6, 2024
ashahba
reviewed
Nov 6, 2024
Signed-off-by: Melanie Buehler <[email protected]>
Fixed typos for MMQA in Docker Image List doc
for more information, see https://pre-commit.ci
Clone specific branch of GenAIComps for tests
ashahba
requested changes
Nov 6, 2024
There was a problem hiding this comment.
Putting this PR on hold until opea-project/GenAIComps#852 is merged.
Signed-off-by: dmsuehir <[email protected]>
Signed-off-by: dmsuehir <[email protected]>
for more information, see https://pre-commit.ci
Signed-off-by: dmsuehir <[email protected]>
Signed-off-by: dmsuehir <[email protected]>
Test update: Increase sleep to 3m to wait for LVM microservice to be ready
|
opea-project/GenAIComps#852 is merged now, please resolve comments from @ashahba . |
Spycsh
approved these changes
Nov 8, 2024
Signed-off-by: Melanie Buehler <[email protected]>
Revert change of repo for tests
|
@tileintel this one is ready to be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the following new features as specified in "Phase 1" of this RFC. The related PR in GenAIComps is opea-project/GenAIComps#852 and it will need to be merged before this one in GenAIExamples.
Data prep and ingestion enhancements:
Other enhancements:
Note that the planned query enhancement "Accept speech audio only" has been moved to Phase 2 and a PR for that phase will be submitted for the next release.
Issues
MultimodalQnA Image & Audio Support RFC
Type of change
List the type of change like below. Please delete options that are not relevant.
Dependencies
No new dependencies
Tests
Updated the individual microservice's test scripts, the GenAIExamples' MultimodalQnA test scripts, and did manual testing of the UI and documented curl commands.