Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vllm: support to run as non-root #882

Merged
merged 1 commit into from
Mar 19, 2025
Merged

Conversation

lianhao
Copy link
Collaborator

@lianhao lianhao commented Mar 19, 2025

Description

Both latest images of opea/vllm and opea/vllm-gaudi needs some special settings to run as non-root.

Issues

n/a.

Type of change

List the type of change like below. Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Dependencies

List the newly introduced 3rd party dependency if exists.

Tests

Describe the tests that you ran to verify your changes.

@lianhao lianhao requested a review from yongfengdu as a code owner March 19, 2025 09:11
@lianhao lianhao requested a review from poussa March 19, 2025 09:12
Copy link
Contributor

@eero-t eero-t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, approved. Suggested comment could be added before merge.

@@ -21,6 +21,7 @@ data:
NUMBA_CACHE_DIR: "/tmp"
HF_HOME: "/tmp/.cache/huggingface"
XDG_CONFIG_HOME: "/tmp"
TORCHINDUCTOR_CACHE_DIR: "/tmp/pytorchinductor_cache"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could add here a comment such as "PyTorch requires root user if cache files are not owned by user".

@eero-t
Copy link
Contributor

eero-t commented Mar 19, 2025

PR description could refer to earlier PR that added the root user usage, and why that was needed:

Latest vLLM enabled support for PyTorch inductor which requires root, if cache files are not owned by the user, but that reason was not known before this PR.

@poussa poussa merged commit 0baa678 into opea-project:main Mar 19, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants