Docsum xeon #280
Merged
Docsum xeon #280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Srinarayan Srikanthan <[email protected]>
srinarayan-srikanthan
requested review from
chensuyue,
ftian1,
mkbhanda,
preethivenkatesh,
chickenrae and
tomlenth
as code owners
|
@mkbhanda , @preethivenkatesh and @tomlenth Please help review and merge this |
Signed-off-by: Srinarayan Srikanthan <[email protected]>
Signed-off-by: Srinarayan Srikanthan <[email protected]>
preethivenkatesh
approved these changes
Jan 17, 2025
Signed-off-by: Srinarayan Srikanthan <[email protected]>
mkbhanda
previously requested changes
Jan 18, 2025
|
@mkbhanda , thank you for the comments, resolved all the comments on xeon and gaudi. |
Signed-off-by: Srinarayan Srikanthan <[email protected]>
|
@srinarayan-srikanthan quick question. have you ask review from code owner of doc sum? |
|
No, i used the readme as reference. I can reach code owner and get a thumbs up |
Signed-off-by: Srinarayan Srikanthan <[email protected]>
Signed-off-by: Srinarayan Srikanthan <[email protected]>
mkbhanda
reviewed
Jan 24, 2025
XinyaoWa
reviewed
Jan 24, 2025
Signed-off-by: Srinarayan Srikanthan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to add tutorial for docsum