Don't output to stdout by default

Signed-off-by: Dominique Vernier <[email protected]>
open-cluster-management-io · Jun 8, 2021 · 5770641 · 5770641
1 parent 2028c84
commit 5770641
Showing 1 changed file with 7 additions and 7 deletions.
diff --git a/pkg/helpers/apply/apply.go b/pkg/helpers/apply/apply.go
@@ -258,14 +258,14 @@ func IsEmptyAsset(err error) bool {
 }
 
 func WriteOutput(fileName string, output []string) (err error) {
-	f := os.Stdout
-	if fileName != "" {
-		f, err = os.OpenFile(filepath.Clean(fileName), os.O_WRONLY|os.O_CREATE, 0600)
-		if err != nil {
-			return err
-		}
-		defer f.Close()
+	if fileName == "" {
+		return nil
+	}
+	f, err := os.OpenFile(filepath.Clean(fileName), os.O_WRONLY|os.O_CREATE, 0600)
+	if err != nil {
+		return err
 	}
+	defer f.Close()
 	for _, s := range output {
 		_, err := f.WriteString(fmt.Sprintf("%s\n---\n", s))
 		if err != nil {