Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Only enable auth driver when type is irsa #777

Conversation

qiujian16
Copy link
Member

This is to ensure during upgrade scenario, the new operator can still start the old version of the agent.

Summary

Related issue(s)

Fixes #

This is to ensure during upgrade scenario, the new operator
can still start the old version of the agent.

Signed-off-by: Jian Qiu <[email protected]>
@openshift-ci openshift-ci bot requested review from deads2k and jnpacker December 23, 2024 08:25
Copy link
Contributor

openshift-ci bot commented Dec 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiujian16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@qiujian16
Copy link
Member Author

it currently causes the upgrade e2e test failure in clusteradm open-cluster-management-io/clusteradm#461

Copy link

codecov bot commented Dec 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.77%. Comparing base (8737358) to head (25f2485).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #777   +/-   ##
=======================================
  Coverage   63.77%   63.77%           
=======================================
  Files         192      192           
  Lines       18596    18596           
=======================================
  Hits        11860    11860           
  Misses       5756     5756           
  Partials      980      980           
Flag Coverage Δ
unit 63.77% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhujian7
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Dec 23, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 8d55919 into open-cluster-management-io:main Dec 23, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants