Skip to content

Conversation

fitsegreat
Copy link
Contributor

No description provided.

@openshift-ci openshift-ci bot requested a review from mprahl June 4, 2025 18:05
Copy link

netlify bot commented Jun 4, 2025

Deploy Preview for open-cluster-management ready!

Name Link
🔨 Latest commit 946d94c
🔍 Latest deploy log https://app.netlify.com/projects/open-cluster-management/deploys/68408d3b1931190008aa3d2f
😎 Deploy Preview https://deploy-preview-486--open-cluster-management.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@openshift-ci openshift-ci bot requested a review from qiujian16 June 4, 2025 18:05
Copy link
Member

@mikeshng mikeshng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix. Just a minor nit.

Copy link
Member

@mikeshng mikeshng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

/lgtm

Just need to sign off your commit. Thanks!

@openshift-ci openshift-ci bot added the lgtm label Jun 4, 2025
Copy link
Contributor

openshift-ci bot commented Jun 4, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fitsegreat, mikeshng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Jun 4, 2025
@xuezhaojun
Copy link
Member

xuezhaojun commented Jul 24, 2025

Hi @fitsegreat, The change looks good and is ready to merge. Would you like to add the DCO sign-off to your commit to comply with our requirements. Thanks for your contribution!

git commit --amend --signoff --no-edit

@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants