Skip to content

chore: add support for Python 3.11 + 3.12 and Django 4.2 + 5.2#278

Merged
Agrendalath merged 5 commits intomasterfrom
agrendalath/bb-10290-ulmo
Jan 28, 2026
Merged

chore: add support for Python 3.11 + 3.12 and Django 4.2 + 5.2#278
Agrendalath merged 5 commits intomasterfrom
agrendalath/bb-10290-ulmo

Conversation

@Agrendalath
Copy link
Member

@Agrendalath Agrendalath commented Jan 11, 2026

Description:
Note: please review this commit-by-commit, as it gives the context of the changes.

This:

  • Drops support for Python 2, Python 3.8, and Django 3.2.
  • Adds support for Python 3.11 + 3.12 and Django 4.2 + 5.2.
  • Fixes the stats API endpoint.
  • Fixes the ENROLLMENT_TRACK_UPDATED signal.
  • Removes unused compat imports.

Merge deadline: None

Testing instructions:

  1. Check that the CI is passing (ignore Codecov, as it's irrelevant in this case).

Private-ref: BB-10290

@Agrendalath Agrendalath self-assigned this Jan 11, 2026
@Agrendalath Agrendalath force-pushed the agrendalath/bb-10290-ulmo branch from e13e77f to b670d47 Compare January 11, 2026 18:08
@Agrendalath Agrendalath marked this pull request as ready for review January 11, 2026 18:10
Copy link

@BryanttV BryanttV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Agrendalath! Thanks for this. Over the last month, we have been using this package with this draft PR, which we planned to publish upstream once the test error was fixed. I see that you did manage to fix it!

On my side, I’ve been testing this branch, and everything works correctly, thank you very much. If you think it’s appropriate, I would recommend using django-upgrade to update the code to Django 4.2. This is the command I used:

git ls-files -z -- '*.py' | xargs -0r django-upgrade --target-version 4.2

@Agrendalath
Copy link
Member Author

Agrendalath commented Jan 16, 2026

@BryanttV, thanks for testing this! Good idea about running django-upgrade - I added its changes in 06c601b.

@Agrendalath Agrendalath force-pushed the agrendalath/bb-10290-ulmo branch from 7d97409 to 170854b Compare January 27, 2026 20:09
"possible": avg_possible,
"earned": total_earned / num_enrollments if num_enrollments else 0,
"percent": total_earned / (avg_possible * num_enrollments) if avg_possible and num_enrollments else 0,
}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note for the review: this one has been broken for a while, but we didn't catch it because we were using Django 3.2 in the CI.

@Agrendalath Agrendalath requested a review from tecoholic January 27, 2026 20:19
Copy link
Member

@tecoholic tecoholic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Agrendalath 👍

  • I tested this: Verified that the CI is passing as expected.
  • I read through the code
  • I checked for accessibility issues - N/A
  • Includes documentation

@Agrendalath Agrendalath force-pushed the agrendalath/bb-10290-ulmo branch from 170854b to b73907f Compare January 28, 2026 14:46
@Agrendalath Agrendalath enabled auto-merge January 28, 2026 14:46
@Agrendalath Agrendalath merged commit 7abc70e into master Jan 28, 2026
9 checks passed
@Agrendalath Agrendalath deleted the agrendalath/bb-10290-ulmo branch January 28, 2026 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants