chore: add support for Python 3.11 + 3.12 and Django 4.2 + 5.2#278
Merged
Agrendalath merged 5 commits intomasterfrom Jan 28, 2026
Merged
chore: add support for Python 3.11 + 3.12 and Django 4.2 + 5.2#278Agrendalath merged 5 commits intomasterfrom
Agrendalath merged 5 commits intomasterfrom
Conversation
e13e77f to
b670d47
Compare
BryanttV
reviewed
Jan 15, 2026
There was a problem hiding this comment.
Hi @Agrendalath! Thanks for this. Over the last month, we have been using this package with this draft PR, which we planned to publish upstream once the test error was fixed. I see that you did manage to fix it!
On my side, I’ve been testing this branch, and everything works correctly, thank you very much. If you think it’s appropriate, I would recommend using django-upgrade to update the code to Django 4.2. This is the command I used:
git ls-files -z -- '*.py' | xargs -0r django-upgrade --target-version 4.2d444c01 to
06c601b
Compare
Member
Author
7d97409 to
170854b
Compare
Agrendalath
commented
Jan 27, 2026
| "possible": avg_possible, | ||
| "earned": total_earned / num_enrollments if num_enrollments else 0, | ||
| "percent": total_earned / (avg_possible * num_enrollments) if avg_possible and num_enrollments else 0, | ||
| } |
Member
Author
There was a problem hiding this comment.
Note for the review: this one has been broken for a while, but we didn't catch it because we were using Django 3.2 in the CI.
tecoholic
approved these changes
Jan 28, 2026
Member
tecoholic
left a comment
There was a problem hiding this comment.
- I tested this: Verified that the CI is passing as expected.
- I read through the code
- I checked for accessibility issues - N/A
- Includes documentation
tecoholic
reviewed
Jan 28, 2026
Importing `student` instead of `common.djangoapps.student` is no longer supported.
170854b to
b73907f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Note: please review this commit-by-commit, as it gives the context of the changes.
This:
statsAPI endpoint.ENROLLMENT_TRACK_UPDATEDsignal.Merge deadline: None
Testing instructions:
Private-ref: BB-10290