chore: fix CI for redwood #819
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samuelallan72
changed the title
samuelallan72
force-pushed
the
samuel/fix-redwood-ci
branch
from
ecd2a03 to
401ad12
Compare
Agrendalath
reviewed
Jan 22, 2026
Agrendalath
reviewed
Jan 22, 2026
Agrendalath
reviewed
Jan 22, 2026
Member
Author
Note to self: this is flagging a legitimate bug in code introduced in #794 |
samuelallan72
force-pushed
the
samuel/fix-redwood-ci
branch
from
b50b093 to
0239234
Compare
Member
Author
I've fixed this and a couple of failing unit tests here too. |
Diff against upstream master workflows and copy across relevant updates wherever possible. This should get the CI running again, and bring the CI more in line with upstream master. Private-ref: https://tasks.opencraft.com/browse/BB-10470
samuelallan72
force-pushed
the
samuel/fix-redwood-ci
branch
from
2078a1c to
7cc93da
Compare
Member
Author
|
@Agrendalath thanks for your review! I've addressed or replied to your comments, and got the CI passing. This is ready for review. :) |
Agrendalath
requested changes
Jan 24, 2026
samuelallan72
force-pushed
the
samuel/fix-redwood-ci
branch
7 times, most recently
from
16c2c49 to
b6c521c
Compare
Also add docstring to keep pylint happy and add some type hints. Relates to #794
It looks like ora2 has been updated, and now has new fields.
samuelallan72
force-pushed
the
samuel/fix-redwood-ci
branch
from
b6c521c to
440ecc8
Compare
samuelallan72
force-pushed
the
samuel/fix-redwood-ci
branch
from
440ecc8 to
128c05f
Compare
Agrendalath
approved these changes
Jan 27, 2026
Member
Agrendalath
left a comment
Agrendalath
left a comment
There was a problem hiding this comment.
👍
- I tested this: checked that the CI is passing
- I read through the code
- I checked for accessibility issues: n/a
- Includes documentation: n/a
- Added to the Code Drift project board (for backports): n/a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Diff against upstream master workflows and copy across relevant updates to bring the CI more inline with upstream master and get it running again. Also fix some failing tests along the way.
Private-ref: https://tasks.opencraft.com/browse/BB-10470