[BB-10439] Update AI Export Script #21
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkulkark
force-pushed
the
pooja/update-export-xblock
branch
from
bc7fecf to
dd5f8f1
Compare
pkulkark
force-pushed
the
pooja/update-export-xblock
branch
from
dd5f8f1 to
7d85362
Compare
Member
samuelallan72
left a comment
samuelallan72
left a comment
There was a problem hiding this comment.
I tested this on the sandbox at it appears to work fine. 👍 I left some code quality nits to address as you see fit. On the documentation side, it would be nice to use type annotations more. :)
The main thing I flagged that I think needs to be addressed as the hardcoding of conversation id for the coach rows.
- I tested this: tested on the sandbox (thanks for deploying to the sandbox for testing!)
- I read through the code
- I checked for accessibility issues
- Includes documentation
Comment on lines
+49
to
+51
| for getter in ( | ||
| _get_course_display_name_from_course_overview, | ||
| _get_course_display_name_from_modulestore, |
Member
There was a problem hiding this comment.
do we really need this fallback logic? Under what circumstances would one or the other fail?
Member
Author
There was a problem hiding this comment.
CourseOverview is a cached representation and may be missing/outdated. I noticed the "CourseOverview first, then modulestore” idea in a couple of other places (like here) and went with the same.
samuelallan72
approved these changes
Jan 9, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the AI conversation history export script as follows:
Supporting information
OpenCraft Internal Jira task: BB-10439
Testing instructions
ai_eval_exportin the advanced module list and add it anywhere in the course and publish.