🐞 Fix model-specific transforms for DRÆM and DSR #2624
Merged
+20
−31
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
These models do not use Imagenet normalization. They had
configure_transforms()
to handle it, but it is never called, so default transforms with Imagenet normalization are applied. The training code is below, printing image values show that they are not between 0 and 1, as they should be.✨ Changes
This PR changes
configure_transforms()
in DRÆM and DSR toconfigure_pre_processor()
to apply model-specific transforms properly.Select what type of change your PR is:
✅ Checklist
Before you submit your pull request, please make sure you have completed the following steps:
For more information about code review checklists, see the Code Review Checklist.