feat(inspect): add, remove list and connect sources #3078

camiloHimura · 2025-10-30T10:02:56Z

📝 Description

This PR introduces the initial implementation of pipeline source integration. The new UI allows users to create, edit, and connect sources to a pipeline. Due to the number of files involved, this functionality will be split across multiple PRs. The upcoming one will focus on UX improvements

#3061

Screen.Recording.2025-10-30.at.10.54.27.mov

Provide a clear summary of the changes and the issue that has been addressed.
🛠️ Fixes # (issue number)

✨ Changes

Select what type of change your PR is:

✅ Checklist

Before you submit your pull request, please make sure you have completed the following steps:

📚 I have made the necessary updates to the documentation (if applicable).
🧪 I have written tests that support my changes and prove that my fix is effective or my feature works (if applicable).
🏷️ My PR title follows conventional commit format.

For more information about code review checklists, see the Code Review Checklist.

Copilot

Pull Request Overview

This PR introduces the initial implementation of pipeline source integration for the inspect feature. The new UI allows users to create, edit, and connect different types of sources (webcam, IP camera, video file, images folder) to a pipeline through a comprehensive configuration interface.

Added pipeline source management functionality with CRUD operations
Implemented source connection/disconnection to pipeline
Created modular source components for different input types with validation

Reviewed Changes

Copilot reviewed 43 out of 46 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
application/ui/vitest.config.ts	Added TypeScript path resolution plugin for testing
application/ui/src/routes/inspect/inspect.tsx	Updated toolbar import path to new nested structure
application/ui/src/index.css	Added new CSS color variables for UI styling
application/ui/src/hooks/use-pipeline.hook.ts	Added comprehensive pipeline management hooks
application/ui/src/features/inspect/toolbar/toolbar.tsx	Refactored toolbar with extracted components and pipeline configuration
application/ui/src/features/inspect/toolbar/sources/*	Complete source management system with components for different source types
application/ui/src/features/inspect/toolbar/pipeline-configuration.component.tsx	Main pipeline configuration dialog with tabbed interface
application/ui/src/features/inspect/toolbar/inference-opacity.tsx	Extracted inference opacity control component
application/ui/src/components/disclosure-group/*	Reusable disclosure group component for expandable UI sections
application/ui/src/assets/icons/index.ts	Added pipeline link icon export
application/ui/package.json	Added vite-tsconfig-paths dependency

Files not reviewed (1)

application/ui/package-lock.json: Language not supported

Comments suppressed due to low confidence (1)

application/ui/src/features/inspect/toolbar/sources/image-folder/image-folder-fields.module.scss:1

Double var() usage is incorrect CSS syntax. Should be var(--spectrum-accent-background-color-hover).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

...i/src/features/inspect/toolbar/sources/source-list/settings-list/settings-list.component.tsx

application/ui/src/features/inspect/toolbar/sources/video-file/video-file-fields.module.scss

application/ui/src/features/inspect/toolbar/sources/edit-source/edit-source.module.scss

Copilot

Pull Request Overview

Copilot reviewed 43 out of 46 changed files in this pull request and generated 3 comments.

Files not reviewed (1)

application/ui/package-lock.json: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

application/ui/src/features/inspect/toolbar/sources/add-source/add-source.test.tsx

...i/src/features/inspect/toolbar/sources/source-list/settings-list/settings-list.component.tsx

application/ui/src/features/inspect/toolbar/sources/source-menu/source-menu.component.tsx

codecov-commenter · 2025-10-30T10:39:26Z

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

ashwinvaidya17

Looks good to me. One super nitpicky comment but tbh I have no comments regarding UI code.

ashwinvaidya17 · 2025-10-30T13:42:39Z

application/ui/src/features/inspect/toolbar/sources/source-list/utils.ts

@@ -0,0 +1,3 @@
+export const removeUnderscore = (text: string) => {


Maybe nitpicky but is this needed? Maybe we can make it inline

It’s possible, but I’ll be reusing it in an upcoming PR, so it’s useful to keep it as a reusable function

MarkRedeman

Than you Camilo! I added quite some comments but really like the progress.
I don't have any big blockers, more some open design suggestions that we can look into.

...ation/ui/src/features/inspect/toolbar/sources/image-folder/image-folder-fields.component.tsx

application/ui/src/assets/icons/index.ts

application/ui/src/features/inspect/toolbar/sources/add-source/add-source.component.tsx

application/ui/src/features/inspect/toolbar/sources/util.ts

application/ui/src/features/inspect/toolbar/sources/source-actions.component.tsx

application/ui/src/features/inspect/toolbar/sources/source-factory.component.tsx

application/ui/vitest.config.ts

application/ui/src/providers.tsx

Signed-off-by: Colorado, Camilo <[email protected]>

Copilot

Pull Request Overview

Copilot reviewed 46 out of 49 changed files in this pull request and generated 8 comments.

Files not reviewed (1)

application/ui/package-lock.json: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

application/ui/vitest.config.ts

application/ui/src/features/inspect/train-model/train-model-dialog.component.tsx

application/ui/src/features/inspect/toolbar/sources/ip-camera/utils.ts

application/ui/src/features/inspect/toolbar/sources/image-folder/utils.ts

...on/ui/src/features/inspect/toolbar/sources/source-list/source-icon/source-icon.component.tsx

...i/src/features/inspect/toolbar/sources/source-list/settings-list/settings-list.component.tsx

application/ui/src/features/inspect/toolbar/pipeline-configuration.component.tsx

Signed-off-by: Colorado, Camilo <[email protected]>

Copilot

Pull Request Overview

Copilot reviewed 46 out of 49 changed files in this pull request and generated no new comments.

Files not reviewed (1)

application/ui/package-lock.json: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

…rm#3078) * group disclosure config Signed-off-by: Colorado, Camilo <[email protected]> * render SourceOptions Signed-off-by: Colorado, Camilo <[email protected]> * update vites config Signed-off-by: Colorado, Camilo <[email protected]> * render sourcer list and connection status Signed-off-by: Colorado, Camilo <[email protected]> * implement EditSource component Signed-off-by: Colorado, Camilo <[email protected]> * refactor api-camera, split it in two components * refactor edit and new source components * display source config details Signed-off-by: Colorado, Camilo <[email protected]> * add SourceMenu unit tests Signed-off-by: Colorado, Camilo <[email protected]> * update source API * update forms with projectId * fix Pr comments Signed-off-by: Colorado, Camilo <[email protected]> --------- Signed-off-by: Colorado, Camilo <[email protected]>

camiloHimura requested a review from MarkRedeman October 30, 2025 10:02

camiloHimura requested a review from samet-akcay as a code owner October 30, 2025 10:02

Copilot AI review requested due to automatic review settings October 30, 2025 10:02

Copilot AI reviewed Oct 30, 2025

View reviewed changes

camiloHimura force-pushed the ccolora11/3061-sources branch from b91b7a0 to 14fcf99 Compare October 30, 2025 10:11

Copilot AI review requested due to automatic review settings October 30, 2025 10:13

camiloHimura force-pushed the ccolora11/3061-sources branch from 14fcf99 to 49d8b62 Compare October 30, 2025 10:13

Copilot AI reviewed Oct 30, 2025

View reviewed changes

camiloHimura requested a review from ActiveChooN October 30, 2025 10:20

ashwinvaidya17 approved these changes Oct 30, 2025

View reviewed changes

MarkRedeman mentioned this pull request Nov 3, 2025

Refactor(inspect): sources and sinks under project #3079

Merged

15 tasks

MarkRedeman reviewed Nov 3, 2025

View reviewed changes

camiloHimura added 11 commits November 4, 2025 20:53

group disclosure config

45c33ed

Signed-off-by: Colorado, Camilo <[email protected]>

render SourceOptions

aec1b16

Signed-off-by: Colorado, Camilo <[email protected]>

update vites config

1cc0da8

Signed-off-by: Colorado, Camilo <[email protected]>

render sourcer list and connection status

ee2be6b

Signed-off-by: Colorado, Camilo <[email protected]>

implement EditSource component

39fc232

Signed-off-by: Colorado, Camilo <[email protected]>

refactor api-camera, split it in two components

aa0afc8

refactor edit and new source components

902c330

display source config details

93e3e09

Signed-off-by: Colorado, Camilo <[email protected]>

add SourceMenu unit tests

52c10e9

Signed-off-by: Colorado, Camilo <[email protected]>

update source API

08f9cab

update forms with projectId

3ef00d1

camiloHimura force-pushed the ccolora11/3061-sources branch from fcd52f9 to 5647c05 Compare November 5, 2025 01:09

Copilot AI review requested due to automatic review settings November 5, 2025 01:09

Copilot AI reviewed Nov 5, 2025

View reviewed changes

camiloHimura force-pushed the ccolora11/3061-sources branch from 5647c05 to 97f72da Compare November 5, 2025 01:25

fix Pr comments

292a8dd

Signed-off-by: Colorado, Camilo <[email protected]>

Copilot AI review requested due to automatic review settings November 5, 2025 01:36

camiloHimura force-pushed the ccolora11/3061-sources branch from 97f72da to 292a8dd Compare November 5, 2025 01:36

Copilot AI reviewed Nov 5, 2025

View reviewed changes

MarkRedeman approved these changes Nov 5, 2025

View reviewed changes

camiloHimura merged commit 87a1efe into open-edge-platform:feature/geti-inspect Nov 5, 2025
15 of 17 checks passed

		@@ -0,0 +1,3 @@
		export const removeUnderscore = (text: string) => {

feat(inspect): add, remove list and connect sources #3078

feat(inspect): add, remove list and connect sources #3078

Uh oh!

Conversation

camiloHimura commented Oct 30, 2025

📝 Description

✨ Changes

✅ Checklist

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codecov-commenter commented Oct 30, 2025

Codecov Report

Uh oh!

ashwinvaidya17 left a comment

Choose a reason for hiding this comment

Uh oh!

ashwinvaidya17 Oct 30, 2025

Choose a reason for hiding this comment

Uh oh!

camiloHimura Nov 5, 2025

Choose a reason for hiding this comment

Uh oh!

MarkRedeman left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants