Migrate services from installer to pre-installer #938
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garyloug
force-pushed
the
pre-installer_installer
branch
from
cd7e5fd to
32d1a6a
Compare
Move AWS-specific queries, EFS file system ID and load balancer target group ARN, from configure-cluster.sh to provision.sh - Add efs_file_system_id to output.tf - Export FILE_SYSTEM_ID to ~/.env after cluster apply - Export target group ARNs to ~/.env after loadbalancer apply - Update configure-cluster.sh to read these from ~/.env
Replace get_s3_prefix() terraform query with variable export to remove dependency on terraform in the installer. - Add s3_prefix to output.tf - Export S3_PREFIX to ~/.env after cluster apply in provision.sh - Replace get_s3_prefix with env var read in configure-cluster.sh
Remove update_kube_config from installer script configure-cluster.sh This function calls "aws eks update-kubeconfig". However, the pre-installer script provision.sh calls a function called connect_cluster. This connect_cluster function also calls "aws eks update-kubeconfig". The call in the installer appears redundant, so it is removed to remove AWS dependency from the installer. Added new script reconnect-aws-cluster.sh for the usecase where a user might be running pre-installer and installer in different shell sessions.
- Add 7 TF outputs to output.tf - Export these values to ~/.env in provision.sh - Remove load_provision_values call from configure-cluster.sh
garyloug
force-pushed
the
pre-installer_installer
branch
from
140d5a8 to
a094beb
Compare
garyloug
requested review from
Ram-srini,
SushilLakra,
cjnolan,
damiankopyto,
guptagunjan,
hyunsun,
johnoloughlin,
krishnajs,
palade,
rranjan3,
scottmbaker,
shankarsrinivas1,
soniabha-intc and
sys-orch-approve
as code owners
Move AWS-specific queries, EFS file system ID and load balancer target group ARN, from configure-cluster.sh to provision.sh - Add efs_file_system_id to output.tf - Export FILE_SYSTEM_ID to ~/.env after cluster apply - Export target group ARNs to ~/.env after loadbalancer apply - Update configure-cluster.sh to read these from ~/.env
Replace get_s3_prefix() terraform query with variable export to remove dependency on terraform in the installer. - Add s3_prefix to output.tf - Export S3_PREFIX to ~/.env after cluster apply in provision.sh - Replace get_s3_prefix with env var read in configure-cluster.sh
Remove update_kube_config from installer script configure-cluster.sh This function calls "aws eks update-kubeconfig". However, the pre-installer script provision.sh calls a function called connect_cluster. This connect_cluster function also calls "aws eks update-kubeconfig". The call in the installer appears redundant, so it is removed to remove AWS dependency from the installer. Added new script reconnect-aws-cluster.sh for the usecase where a user might be running pre-installer and installer in different shell sessions.
- Add 7 TF outputs to output.tf - Export these values to ~/.env in provision.sh - Remove load_provision_values call from configure-cluster.sh
scottmbaker
approved these changes
Nov 4, 2025
- Include reconnect-aws-cluster.sh in installer container - Remove S3_PREFIX from required variables check in configure-cluster.sh - Add kubectl config setup to configure-cluster.sh - Add single_tenancy terraform variable - Move terminate_sshuttle after wait_for_gitea to keep tunnel alive during Gitea check
garyloug
force-pushed
the
pre-installer_installer
branch
from
c4d4401 to
1e9087e
Compare
Add missing variables. Check user is sourcing.
garyloug
force-pushed
the
pre-installer_installer
branch
from
43c3c78 to
10f88e8
Compare
These have been implemented elsewhere in the codebase.
palade
approved these changes
Nov 7, 2025
johnoloughlin
approved these changes
Nov 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the changes and the related issue. List any dependencies that are required for this change.
Fixes # (issue)
Any Newly Introduced Dependencies
Please describe any newly introduced 3rd party dependencies in this change. List their name, license information and how they are used in the project.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: