feat: pass missing model_info #472
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
tests
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enables the use of ModelAPI with generic OpenVINO models that lack embedded metadata by allowing users to provide required metadata through the configuration parameter. The change allows model_type and other preprocessing/postprocessing parameters to be supplied externally when models don't have rt_info/model_info fields.
Changes:
- Added fallback to use
configuration["model_type"]when metadata is missing from the model - Propagated
configurationparameter through test infrastructure - Added test case for model without embedded metadata
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/model_api/models/model.py | Modified to use configuration-provided model_type as fallback when rt_info is unavailable |
| tests/accuracy/test_accuracy.py | Added configuration parameter support throughout the test infrastructure |
| tests/accuracy/public_scope.json | Added test case for model without embedded model_info metadata |
| README.md | Added documentation example showing how to use configuration parameter with generic models |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
mgumowsk
previously approved these changes
Jan 19, 2026
Co-authored-by: Mariusz Gumowski <[email protected]>
mgumowsk
approved these changes
Jan 20, 2026
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR enables the use of ModelAPI with generic OpenVINO models that lack embedded metadata by allowing users to provide required metadata through the
configurationparameter. The change allowsmodel_typeand other preprocessing/postprocessing parameters to be supplied externally when models don't havert_info/model_infofields.Changes:
configuration["model_type"]when metadata is missing from the modelconfigurationparameter through test infrastructureFixes #471
Before submitting