New turn algorighm #15
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(Need to add control to editor)
|
I've added @cjsha to the repo so that he can review this as well, as I do not have a commutator to test with. @aacuevas I believe this would be a minor increase, since it is more than a bug fix. Also, I saw in the commit message that we need to add a control to the editor, is that something I can help with? |
|
There is a related PR in open-ephys/bonsai-commutator#14 that includes this same algorithm. Cris will probably test that version first for ease of testing. Regarding the control, I want to discuss this change first, maybe on next meeting. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements a more robust quaternion to turn algorithm.
Not sure if this should be a patch or minor version increase
With this change, the axis selector on the plugin properly defines which axis on the IMU, from its physical representation, is to be used for turning computations.