Skip to content

Add specific cases to device specification #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 9, 2025
Merged

Add specific cases to device specification #94

merged 5 commits into from
Apr 9, 2025

Conversation

aacuevas
Copy link
Contributor

@aacuevas aacuevas commented Mar 5, 2025

@aacuevas aacuevas requested a review from jonnew March 5, 2025 03:23
jonnew
jonnew reviewed Mar 6, 2025
View reviewed changes
Copy link
Member

@jonnew jonnew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some pending text changes, but ill wait for the responses to my comments before committing them.

@jonnew
Copy link
Member

jonnew commented Mar 7, 2025

I made some edits the the detachable devices page, please review and change as you wish.

@aacuevas
Copy link
Contributor Author

aacuevas commented Mar 8, 2025

Ok, I think it should be done now. Please review the last changes, I followed the earlier comments.

On the detachable devices page, I do reference the soft reset, we need to link it to the appropriate tag once #91 is merged

@jonnew jonnew self-requested a review April 7, 2025 15:23
aacuevas and others added 4 commits April 9, 2025 13:00
@jonnew jonnew mentioned this pull request Apr 9, 2025
Merged
@jonnew
Improve word choice and remove redundancy
9e02ea0 
- Don't re-explain null-device requirements, just link to the null
  device page
@jonnew jonnew merged commit 707c3e2 into main Apr 9, 2025
2 checks passed
@jonnew jonnew deleted the issue-77 branch April 9, 2025 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonnew jonnew jonnew approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create spec for "detachable devices"
2 participants
@aacuevas @jonnew